Point out when a callable is not actually callable because its return is not sized #101359
+47
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Sep 3, 2022
lcnr
reviewed
Sep 5, 2022
| && !self.type_is_sized_modulo_regions(self.param_env, output_ty, callee_expr.span) | ||
| { | ||
| let descr = match maybe_def { | ||
| super::DefIdOrName::DefId(def_id) => self.tcx.def_kind(def_id).descr(def_id), |
There was a problem hiding this comment.
nit: want to import DefIdOrName instead 😁
after that r=me
compiler-errors
force-pushed
the
cannot-call-trait-object-with-unsized-return
branch
from
2ec5902 to
1254b32
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (098cf88): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
compiler-errors
deleted the
cannot-call-trait-object-with-unsized-return
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100755
I didn't add a UI test for that one because it's equivalent to the UI test that already exists in the suite.